aboutsummaryrefslogtreecommitdiff
path: root/src/dk.biks.bachelorizer/dk/biks
diff options
context:
space:
mode:
authorJonas Smedegaard <dr@jones.dk>2025-04-29 06:03:56 +0200
committerJonas Smedegaard <dr@jones.dk>2025-04-29 06:11:41 +0200
commita5c3599d7bc7a9ef5583ad2d50a55975f030fbea (patch)
treedb4ed74e48997d4b4450148116a9c990978a1641 /src/dk.biks.bachelorizer/dk/biks
parent03d2d06e8f5bfadd79912efb94e8931e54296735 (diff)
declare variables final when possible
Diffstat (limited to 'src/dk.biks.bachelorizer/dk/biks')
-rw-r--r--src/dk.biks.bachelorizer/dk/biks/bachelorizer/Control.java6
-rw-r--r--src/dk.biks.bachelorizer/dk/biks/bachelorizer/GUI.java4
-rw-r--r--src/dk.biks.bachelorizer/dk/biks/bachelorizer/Graph.java12
-rw-r--r--src/dk.biks.bachelorizer/dk/biks/bachelorizer/Main.java2
-rw-r--r--src/dk.biks.bachelorizer/dk/biks/bachelorizer/Person.java2
-rw-r--r--src/dk.biks.bachelorizer/dk/biks/bachelorizer/Window.java10
6 files changed, 18 insertions, 18 deletions
diff --git a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Control.java b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Control.java
index 320b36c..1b0e4e5 100644
--- a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Control.java
+++ b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Control.java
@@ -22,7 +22,7 @@ public class Control{
///
/// @param model Application model
/// @param view Application view
- public Control(GUI model, Window view){
+ public Control(final GUI model, final Window view){
this.model = model;
this.view = view;
}
@@ -36,7 +36,7 @@ public class Control{
/// and remaining ones as activity selections
///
/// @param parameters Application parameters
- public void setParameters(List<String> parameters) {
+ public void setParameters(final List<String> parameters) {
boolean optionsDone = false;
boolean studentAssigned = false;
for (String item : parameters) {
@@ -58,7 +58,7 @@ public class Control{
/// Enter activity
///
/// @param s String entered
- public void enterActivity(String s){
+ public void enterActivity(final String s){
model.addActivity(s);
view.clearActivityEntry();
showActivities();
diff --git a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/GUI.java b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/GUI.java
index 695c19c..1591f07 100644
--- a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/GUI.java
+++ b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/GUI.java
@@ -22,7 +22,7 @@ public class GUI{
/// Add student
///
/// @param name Name of student
- public void addStudent(String name){
+ public void addStudent(final String name){
student = new Person(name);
}
@@ -36,7 +36,7 @@ public class GUI{
/// Add activity to list
///
/// @param s Activity to add
- public void addActivity(String s){
+ public void addActivity(final String s){
list.add(s);
}
diff --git a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Graph.java b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Graph.java
index ed38f1d..1382a4a 100644
--- a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Graph.java
+++ b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Graph.java
@@ -120,7 +120,7 @@ public final class Graph {
/// @param g Graph to inspect
/// @throws IllegalArgumentException
/// https://docs.oracle.com/javase/tutorial/essential/exceptions/runtime.html
- public static void assertConnected(AbstractGraph g) {
+ public static void assertConnected(final AbstractGraph g) {
// collect all vertices in the graph
Collection<Vertex> c = g.vertices();
@@ -143,7 +143,7 @@ public final class Graph {
///
/// @param g Graph to inspect
/// @return list of disjoint sets
- public static ArrayList<Set<Vertex>> disjoint(AbstractGraph g) {
+ public static ArrayList<Set<Vertex>> disjoint(final AbstractGraph g) {
// get all subject modules
//
@@ -159,7 +159,7 @@ public final class Graph {
/// @param g Graph to inspect
/// @param vip Ordered list of subject modules to prioritize
/// @return List of sets of disjoint choices
- public static ArrayList<Set<Vertex>> disjoint(AbstractGraph g, List<Vertex> vip) {
+ public static ArrayList<Set<Vertex>> disjoint(final AbstractGraph g, final List<Vertex> vip) {
ArrayList<Set<Vertex>> sets = new ArrayList<>();
// track done subject modules as extendable set
@@ -205,7 +205,7 @@ public final class Graph {
/// @param sets list of disjoint choices
/// @param g choices as weights in graph
/// @return groups of disjoint choices as a graph
- public static AbstractGraph moduleGroups(ArrayList<Set<Vertex>> sets, AbstractGraph g) {
+ public static AbstractGraph moduleGroups(final ArrayList<Set<Vertex>> sets, final AbstractGraph g) {
AbstractGraph h = new AdjListGraph();
for (Set<Vertex> s: sets) {
for (Set<Vertex> t: sets) {
@@ -230,7 +230,7 @@ public final class Graph {
///
/// @param g sets of disjoint choices as a graph
/// @return amount of students in consecutive slots
- public static int solution(AbstractGraph g) {
+ public static int solution(final AbstractGraph g) {
// pick a random vertice in the graph
Vertex v = g.vertices().iterator().next();
@@ -243,7 +243,7 @@ public final class Graph {
/// @param g groups of disjoint choices as a graph
/// @param v seed vertex within graph
/// @return amount of students in consecutive slots
- public static int solution(AbstractGraph g, Vertex v) {
+ public static int solution(final AbstractGraph g, final Vertex v) {
return GraphAlgorithms.pathLength(
GraphAlgorithms.dijkstra(g, v));
}
diff --git a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Main.java b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Main.java
index 55ae0c1..10092c8 100644
--- a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Main.java
+++ b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Main.java
@@ -65,7 +65,7 @@ public class Main {
///
/// @param args command-line arguments
/// @return choice of UI as String
- public static String uiFromArgs(String[] args) {
+ public static String uiFromArgs(final String[] args) {
// TODO: make "cli" the default when implemented
String defaultUI = "gui";
diff --git a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Person.java b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Person.java
index f7eeab3..7435550 100644
--- a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Person.java
+++ b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Person.java
@@ -12,7 +12,7 @@ public class Person {
/// Constructor
///
/// @param name Name of person
- public Person (String name) {
+ public Person (final String name) {
this.name = name;
}
}
diff --git a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Window.java b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Window.java
index ec8b822..475de52 100644
--- a/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Window.java
+++ b/src/dk.biks.bachelorizer/dk/biks/bachelorizer/Window.java
@@ -52,12 +52,12 @@ public final class Window extends Application {
/// Application instantiation
///
/// @param args application parameters
- public static void main(String[] args) {
+ public static void main(final String[] args) {
launch(args);
}
@Override
- public void start(Stage stage) {
+ public void start(final Stage stage) {
// pass application parameters to controller
control.setParameters(getParameters().getRaw());
@@ -87,14 +87,14 @@ public final class Window extends Application {
/// action to apply student name
///
/// @param s Text to apply
- public void setStudentName(String s) {
+ public void setStudentName(final String s) {
nameEntry.setText(s);
}
/// action to apply text to area
///
/// @param s Text to apply
- public void setArea(String s) {
+ public void setArea(final String s) {
area.setText(s);
}
@@ -108,7 +108,7 @@ public final class Window extends Application {
/// @param s Label string
/// @param f Text field
/// @return HBox containing styled label and text field
- public HBox ourHBox(String s, TextField f) {
+ public HBox ourHBox(final String s, final TextField f) {
Label label = new Label(s+":");
label.setStyle(LABEL_STYLE);